feat: update lerna, eslint and some format changes #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: fix issues with latest linter version
|
|
Hm ... what benefits your PR have over mine #1376 ? |
ericzon
approved these changes
Mar 6, 2025
|
@ericzon You might better want to approve my PR rather then this one, or? |
|
[heart] GAMITO ROMERO Ana reacted to your message:
…________________________________
From: Eric ***@***.***>
Sent: Thursday, March 6, 2025 5:07:51 PM
To: axa-group/nlp.js ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [EXTERNAL] Re: [axa-group/nlp.js] feat: update lerna, eslint and some format changes (PR #1377)
@ericzon approved this pull request.
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/axa-group/nlp.js/pull/1377*pullrequestreview-2665113476__;Iw!!BnkV9pdh5V0!DOdm8X10LP96n5Mh7eZfmLsJyjcdBeyyVfbibSJEMwr8EJejWj71vEd_ahe2LytgYyHqMxCi0KNqK6B6vjmYFyo$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AGL7XK7K34HHFT63ZTINT5T2TB6GPAVCNFSM6AAAAABV5VOSUCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDMNRVGEYTGNBXGY__;!!BnkV9pdh5V0!DOdm8X10LP96n5Mh7eZfmLsJyjcdBeyyVfbibSJEMwr8EJejWj71vEd_ahe2LytgYyHqMxCi0KNqK6B6ewuwPCo$>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
Este mensaje es confidencial; su contenido no constituye compromiso alguno por parte de AXA Group Operations Spain SA, excepto si mediase un acuerdo escrito entre Usted y AXA Group Operations Spain SA. Se prohíben la revelación, el uso o la difusión de dicho contenido, ya sea total o parcialmente. Si no es Usted el destinatario al que va dirigido el mensaje, por favor, notifíqueselo al remitente inmediatamente.
This message is confidential; its contents do not constitute a commitment by AXA Group Operations Spain SA except where provided for in a written agreement between you and AXA Group Operations Spain SA. Any unauthorised disclosure, use or dissemination, either whole or partial, is prohibited. If you are not the intended recipient of the message, please notify the sender immediately.-
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
PR Checklist
npm testlocally and all tests are passing.PR Description
This PR manages only the following: