SO-5872 Resource has upgrade #1199
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmark
requested changes
Sep 5, 2023
| // create a version for the resource | ||
| return new BranchSnapshotContentRequest<>(Branch.MAIN_PATH, | ||
| new ResourceRepositoryCommitRequestBuilder() | ||
| .setBody(tx -> { | ||
| dependentResourceIds.forEach(id -> { | ||
| ResourceDocument oldDocument = tx.lookup(id, ResourceDocument.class); |
There was a problem hiding this comment.
Would be better to lookup these resources in bulk.
| @@ -195,10 +197,35 @@ public Boolean execute(RepositoryContext context) { | |||
| monitor.worked(1); | |||
| // }); | |||
|
|
|||
| //Find resources that depend on this resource | |||
| List<String> dependentResourceIds = ResourceRequests.prepareSearch() | |||
There was a problem hiding this comment.
If you only need the ID then please use field selection.
| .map(Resource::getId) | ||
| .collect(Collectors.toList()); | ||
|
|
||
| if (resourceToVersion instanceof TerminologyResourceCollection) { |
There was a problem hiding this comment.
This is incorrect, when versioning a collection the system will version all child resources. This will be handled in a different issue, please remove this block.
| //Find resources that depend on this resource | ||
| List<String> dependentResourceIds = ResourceRequests.prepareSearch() | ||
| .setLimit(10_000) | ||
| .filterByDependency(String.format("(uri:%s OR uri:%s/* OR uri:%s\\?*) AND scope:domain) ", resource, resource, resource)) |
There was a problem hiding this comment.
Restricting to just the domain scope is an invalid assumption. This code should work regardless of the scope value of the dependency entries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.