Skip to content
This repository has been archived by the owner on Aug 18, 2021. It is now read-only.

Commit

Permalink
add peer dependency for eslint < 2, since users should be using v6
Browse files Browse the repository at this point in the history
  • Loading branch information
@hzoo
hzoo committed Mar 26, 2016
1 parent fd58c24 commit e29eedb
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
"type": "git",
"url": "https://github.com/babel/babel-eslint.git"
},
"peerDependencies": {
"eslint": "<2.0.0"
},
"dependencies": {
"acorn-to-esprima": "^2.0.4",
"babel-traverse": "^6.0.20",
Expand Down

4 comments on commit e29eedb

@feross
Copy link

@feross feross commented on e29eedb Mar 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this broke the build for standard. I understand you want folks to use the latest version, but was this necessary?

@hzoo
Copy link
Member Author

@hzoo hzoo commented on e29eedb Mar 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @feross. I only added it in since someone suggested it in #267 (comment) (although < 2.3.0, so maybe just change it to that) - many people were having issues so I thought it made sense.

The ESLint 2 issue (#254) was open for a long time and since it had breaking changes it made sense to create a new major version to support it since it would be by chance v5 still worked? You think I should remove it, (I'm ok with this but I'm thinking users in eslint, babel-eslint, and standard repos might make issues wondering why it's not working)?

Basically lot of tests don't pass when using [email protected] with [email protected] and users were having issues.

@hzoo
Copy link
Member Author

@hzoo hzoo commented on e29eedb Mar 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I changed it to < 2.3.0 due to the estraverse-fb issue.

@feross
Copy link

@feross feross commented on e29eedb Mar 30, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Thanks for explaining!

Please sign in to comment.