Updates @babel/plugin-syntax-dynamic-import core-js module paths (core-js@3) #2037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbottigliero
commented
May 24, 2019
jbottigliero
commented
- Adds core-js@3 plugin path varients to documentation.
…e-js@3) - Adds core-js@3 plugin path varients to documentation.
|
Deploy preview for babel ready! Built with commit 874b3aa |
| @@ -44,8 +44,12 @@ Currently, `@babel/preset-env` is unaware that using `import()` with [Webpack re | |||
| // webpack config | |||
| const config = { | |||
| entry: [ | |||
| // using core-js@2 | |||
| "core-js/modules/es.promise", | |||
There was a problem hiding this comment.
This is already for core-js@3: core-js@2 uses es6. instead of es..
Also, those files exist in core-js@3: https://unpkg.com/[email protected]/modules/
There was a problem hiding this comment.
I was seeing module resolution errors with the (internal) modules/ based paths after swapping the configuration over to core-js@3 and found swapping to the /stable/ variants to be the solution.
Something else could certainly be the cause of the resolution error if the es. version is supported... sounds like this change shouldn't be necessary?
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.