Supporting the NO_GLOBAL_SERIAL global definition #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 26, 2022 18:33
…BAL_SERIAL) block
…BAL_SERIAL) block, indented with spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NO_GLOBAL_SERIAL
..is a global definition on the ESP32 Arduino platform which skips defining the Serial, Serial1 and Serial2 objects, leaving the user free to define these themselves. This is a great way of ensuring no other library uses a Serial port for anything we don't want it to, as it immediately generates a compile error.
Unfortunately the legacy begin() function is one of those functions that reference the global Serial object.
So, I forked and added an #if defined(NO_GLOBAL_SERIAL) block inside the legacy begin() function so that PacketSerial is aware of this flag and does not try to link against the Serial object that doesn't exist. That's the only change I've made. The library itself works beautifully, very useful, thank you for making it!