Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize setup and supported versions #118

Merged
merged 7 commits into from
Jan 6, 2023
Merged

Modernize setup and supported versions #118

merged 7 commits into from
Jan 6, 2023

Conversation

nikolaik
Copy link
Contributor

  • Only support Python 3.6+
  • Swig 4
  • Github actions instead of Travis CI
  • requirements_test.txt

aminya
aminya approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@aminya aminya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would appreciate some version updates after a year

nikolaik and others added 3 commits January 6, 2023 08:45
@nikolaik @aminya
Apply suggestions from code review
7861df8 
Co-authored-by: Amin Yahyaabadi <[email protected]>
@bakwc @aminya
Update .github/workflows/build_and_test.yml
1133576 
Co-authored-by: Amin Yahyaabadi <[email protected]>
@bakwc @aminya
Update setup.py
e083509 
Co-authored-by: Amin Yahyaabadi <[email protected]>
@bakwc bakwc merged commit e1b177a into bakwc:master Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aminya aminya aminya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikolaik @aminya @bakwc