Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add build option to use boost.locale instead of std::codecvt to compile on GCC < 5 #13

Conversation

reefactor
Copy link
Contributor

Hey, here is workaround for #12
Although it looks like a boilerplate of cmake for a small regression ^)

@reefactor
Copy link
Contributor Author

reefactor commented Apr 5, 2018

I was unable to push branch directly to your repo:

Username for 'https://github.com': reefactor
Password for 'https://[email protected]': 
remote: Permission to bakwc/JamSpell.git denied to reefactor.
fatal: unable to access 'https://github.com/bakwc/JamSpell.git/': The requested URL returned error: 403

So I made this cross-fork-pull-request.
Can you add me to contributors?

@bakwc bakwc merged commit 41ccef0 into bakwc:master Apr 5, 2018
@bakwc
Copy link
Owner

bakwc commented Apr 5, 2018

Thanks for you PR! There is no need to add to contributors for a single PR. I can add you if you plan to make more improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants