Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deployment preparation: Balancer Contract Registry Initializer #202

Merged
merged 15 commits into from
Mar 14, 2025
Merged

Deployment preparation: Balancer Contract Registry Initializer #202

merged 15 commits into from
Mar 14, 2025

Conversation

EndymionJkb
Copy link
Collaborator

@EndymionJkb EndymionJkb commented Mar 4, 2025 •
edited
Loading

Deployment preparation: Balancer Contract Registry Initializer

build-info: balancer/balancer-v3-monorepo@e1ae7f0

Deployment preparation tasks checklist:

  • Deployments README is updated with the new task name and link
  • Task README has a description and links to the artifacts
  • build-info is updated with artifacts compiled at the specified commit
  • Artifacts are generated from build-info
  • New task has a working fork test

Code checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented in tests and scripts
  • Fork test block number and test cases are appropriate for this deployment
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

@EndymionJkb EndymionJkb changed the title Deployment preparation: Balancer Contract Registry initializer Balancer Contract Registry initialization Mar 4, 2025
@EndymionJkb EndymionJkb changed the title Balancer Contract Registry initialization Deployment preparation: Balancer Contract Registry Initializer Mar 4, 2025
elshan-eth
elshan-eth reviewed Mar 12, 2025
View reviewed changes
Copy link
Contributor

@elshan-eth elshan-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests lgtm, but the ABI and build-info from the commit don't match the PR

build-info: 94cb142d4dd012afe6f4b76b6ec3da02

@EndymionJkb
Copy link
Collaborator Author

Tests lgtm, but the ABI and build-info from the commit don't match the PR

build-info: 94cb142d4dd012afe6f4b76b6ec3da02

Huh; not sure what happened there. Should match now.

@EndymionJkb EndymionJkb requested a review from elshan-eth March 12, 2025 21:56
joaobrunoah
joaobrunoah approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I compiled the governance-scripts pkg and build-info matches.

@EndymionJkb EndymionJkb merged commit 078b296 into master Mar 14, 2025
42 checks passed
@EndymionJkb EndymionJkb deleted the deployment-preparation/registry-initializer branch March 14, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaobrunoah joaobrunoah joaobrunoah approved these changes

@elshan-eth elshan-eth Awaiting requested review from elshan-eth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EndymionJkb @joaobrunoah @elshan-eth