Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment Preparation: GyroECLPPoolFactory #204

Merged
merged 2 commits into from
Mar 14, 2025

Conversation

EndymionJkb
Copy link
Collaborator

Deployment preparation: GyroECLPPoolFactory

This version makes no changes to the ECLP code, but updates to the current BasePoolContract base code, which uses the BaseSplitCodeFactory. This will hopefully allow it to be deployed on low-gas-limit networks like Gnosis.

Since there no semantic changes, just updates to the build-info, it uses the existing task (which was never deployed).

build-info: balancer/balancer-v3-monorepo@e1ae7f0

Deployment preparation tasks checklist:

  • [N/A] Deployments README is updated with the new task name and link
  • Task README has a description and links to the artifacts
  • build-info is updated with artifacts compiled at the specified commit
  • Artifacts are generated from build-info
  • New task has a working fork test

Code checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented in tests and scripts
  • Fork test block number and test cases are appropriate for this deployment
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

@EndymionJkb EndymionJkb requested a review from danielmkm March 13, 2025 19:35
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I compiled the monorepo with the indicated commit, and build info matches

@EndymionJkb EndymionJkb merged commit 74fd464 into master Mar 14, 2025
42 checks passed
@EndymionJkb EndymionJkb deleted the deployment-preparation/gyro-eclp-split branch March 14, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants