QuantAMM v1 deployment #205
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EndymionJkb
reviewed
Mar 13, 2025
EndymionJkb
reviewed
Mar 13, 2025
EndymionJkb
reviewed
Mar 13, 2025
EndymionJkb
reviewed
Mar 13, 2025
EndymionJkb
reviewed
Mar 13, 2025
EndymionJkb
reviewed
Mar 13, 2025
Co-authored-by: EndymionJkb <[email protected]>
…rotocol/balancer-deployments into QuantAMM-V1-deployment
EndymionJkb
reviewed
Mar 14, 2025
| @@ -35,18 +37,19 @@ export default async (task: Task, { force, from }: TaskRunOptions = {}): Promise | |||
| await task.save({ ChainlinkUsdcOracle: chainlinkUsdcOracleWrapper }); | |||
|
|
|||
| console.log('Deployed ChainlinkUsdcOracle'); | |||
| const accounts = (await hre.ethers.getSigners()) as unknown as string[]; | |||
| const accounts = await hre.ethers.getSigners(); | |||
There was a problem hiding this comment.
Consider defining adminAddress = accounts[0].address for clarity and to future-proof against forgetting ".address"
EndymionJkb
reviewed
Mar 14, 2025
EndymionJkb
reviewed
Mar 14, 2025
Comment on lines
+57
to
+59
| type PoolRoleAccounts = { | ||
| // Define the structure based on Solidity contract | ||
| }; |
There was a problem hiding this comment.
Suggested change
| type PoolRoleAccounts = { | |
| // Define the structure based on Solidity contract | |
| }; | |
| type PoolRoleAcounts = { | |
| pauseManager: string, | |
| swapFeeManager: string, | |
| poolCreator: string, | |
| } |
Could define, or maybe don't need this? You're returning it correctly below:
roleAccounts: {
pauseManager: ZERO_ADDRESS,
swapFeeManager: ZERO_ADDRESS,
poolCreator: ZERO_ADDRESS,
},
There was a problem hiding this comment.
yea just thought it was clearer
EndymionJkb
reviewed
Mar 14, 2025
EndymionJkb
reviewed
Mar 14, 2025
EndymionJkb
reviewed
Mar 14, 2025
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Co-authored-by: EndymionJkb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deployment preparation: QuantAMMWeightedPool
commit TBD post merge
Deployment preparation tasks checklist:
READMEis updated with the new task name and linkREADMEhas a description and links to the artifactsbuild-infois updated with artifacts compiled at the specified commitbuild-infoDeprecating old tasks checklist:
deprecated/directoryREADMEis updated: old task is moved to the 'deprecated' section, and links are updated with thedeprecated/prefixindex.ts,input.tsand fork tests are updatedREADMEis updated with a warning sign, a link to the replacement task and a short descriptionCode checklist:
master, or there's a description of how to mergeIssue Resolution