Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment: Protocol Fee Controller Migration #206

Merged
merged 6 commits into from
Mar 14, 2025

Conversation

EndymionJkb
Copy link
Collaborator

@EndymionJkb EndymionJkb commented Mar 13, 2025

Deployment: Protocol Fee Controller Migration

This is the contract used to perform the Protocol Fee Controller migration. The new contract adds events to enable better tracking by off-chain processes, and also functions to future-proof it for future migrations.

See the Protocol Fee Controller Migration Notion doc for details on the migration process.

Deployment tasks checklist:

  • Contract(s) deployed to all target networks / testnets
  • TX IDs are properly generated
  • Action IDs are generated after deployment (if applicable)
  • Outputs for all target networks are generated, and linked in the task readme
  • Addresses files are up to date with the new deployment
  • Contracts are verified in every network
  • Deployments CHANGELOG is updated
  • There are no code changes of any kind (well, had to move the custom pool deployment to the test file)

Issue Resolution

Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EndymionJkb EndymionJkb merged commit dce0815 into master Mar 14, 2025
42 checks passed
@EndymionJkb EndymionJkb deleted the deployment/protocol-fee-controller-migration branch March 14, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants