Deployment preparation: Vault Factory V2

[EndymionJkb]

Deployment preparation: Vault Factory V2

build-info: balancer/balancer-v3-monorepo@e1ae7f0

This is the new "Vault" task, used to deploy the Vault on new chains. The original Vault task (which contains the Vault artifacts, which are of course unchanged) deploys the ProtocolFeeController inside the VaultFactory, which is incompatible with an upgradeable fee controller: it would always deploy the original controller, so there would need to be an immediate migration. The new VaultFactory accepts the ProtocolFeeController address as an argument to create, rather than deploying it.

This task deploys the VaultFactory as before, then deploys the ProtocolFeeController (V2). Then it calls create on the VaultFactory, passing in the latest Protocol Fee Controller address.

Draft because the fork test is still failing. It says the Vault bytecode doesn't match. What's happening is the evm.runCode() in checkBytecodeAndSaveEVMState is reverting with the unhelpful message: "EvmError { error: 'revert', errorType: 'EvmError' }"

It is actually deploying everything correctly; it just can't verify the Vault. If you get the vault contract using instanceAt with the predicted address, the fork test passes. But since it doesn't verify, it doesn't get saved, and isn't in the output.

Deployment preparation tasks checklist:

• Deployments README is updated with the new task name and link
• Task README has a description and links to the artifacts
• build-info is updated with artifacts compiled at the specified commit
• Artifacts are generated from build-info
• New task has a working fork test

Code checklist:

• The diff is legible and has no extraneous changes
• Complex code has been commented in tests and scripts
• Fork test block number and test cases are appropriate for this deployment
• The base branch is either master, or there's a description of how to merge

Issue Resolution