Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bytecode/gas #1228

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Update bytecode/gas #1228

merged 2 commits into from
Jan 14, 2025

Conversation

EndymionJkb
Copy link
Collaborator

@EndymionJkb EndymionJkb commented Jan 14, 2025 •
edited
Loading

Description

These are out-of-date in main; would decrease diffs in new PRs if we updated this first. Noticed while updating #897.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • [N/A] Complex code has been commented, including external interfaces
  • [N/A] Tests have 100% code coverage
  • [N/A] The base branch is either main, or there's a description of how to merge

Issue Resolution

jubeira
jubeira approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joaobrunoah
joaobrunoah approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EndymionJkb EndymionJkb merged commit 17e0498 into main Jan 14, 2025
13 checks passed
@EndymionJkb EndymionJkb deleted the update-snaps branch January 14, 2025 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubeira jubeira jubeira approved these changes

@joaobrunoah joaobrunoah joaobrunoah approved these changes

@elshan-eth elshan-eth Awaiting requested review from elshan-eth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EndymionJkb @jubeira @joaobrunoah