Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing sqrtQ0 for AclAmm Pool #1320

Merged
merged 16 commits into from
Mar 11, 2025
Merged

Changing sqrtQ0 for AclAmm Pool #1320

merged 16 commits into from
Mar 11, 2025

Conversation

elshan-eth
Copy link
Contributor

Description

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

@elshan-eth elshan-eth changed the title DRAFT: Updating q Setting sqrtQ0 for AclAmm Pool Feb 28, 2025
@elshan-eth elshan-eth changed the title Setting sqrtQ0 for AclAmm Pool Changing sqrtQ0 for AclAmm Pool Mar 3, 2025
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments, but LGTM! There's a logic when pool is "in range" and q0 is updating, that one is not set, but we can do that in the new repo, this PR already adds a lot by creating the interface and updating Q0 when the pool is "out of range".

Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments, but overall it's good to merge. We need to figure out the logic of in range, but we can do that later.

@elshan-eth elshan-eth marked this pull request as ready for review March 11, 2025 18:13
@elshan-eth elshan-eth merged commit b124eb3 into acl-amm-cow-v3 Mar 11, 2025
1 check passed
@elshan-eth elshan-eth deleted the updating-q branch March 11, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants