-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing sqrtQ0 for AclAmm Pool #1320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments, but LGTM! There's a logic when pool is "in range" and q0 is updating, that one is not set, but we can do that in the new repo, this PR already adds a lot by creating the interface and updating Q0 when the pool is "out of range".
Co-authored-by: João Bruno - Balancer Labs <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments, but overall it's good to merge. We need to figure out the logic of in range, but we can do that later.
Description
Type of change
Checklist:
main
, or there's a description of how to mergeIssue Resolution