Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balancer Contract Registry initialization contract #1327

Merged
merged 64 commits into from
Mar 11, 2025
Merged

Conversation

EndymionJkb
Copy link
Collaborator

@EndymionJkb EndymionJkb commented Mar 4, 2025

Description

This is a helper contract used by the Balancer Contract Registry initialization. It is based on #1299, since that PR introduced the governance script package, which this also uses.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Optimization: [ ] gas / [ ] bytecode
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • Complex code has been commented, including external interfaces
  • Tests have 100% code coverage
  • The base branch is either main, or there's a description of how to merge

Issue Resolution

Resolves #1291

# Conflicts:
#	pkg/pool-stable/test/foundry/E2eBatchSwap.t.sol
#	pkg/pool-stable/test/foundry/E2eErc4626Swaps.t.sol
#	pkg/pool-stable/test/foundry/E2eSwapRateProvider.t.sol
#	pkg/pool-weighted/test/foundry/E2ESwapRateProvider.t.sol
# Conflicts:
#	pkg/pool-weighted/test/foundry/E2eSwap.t.sol
# Conflicts:
#	pkg/interfaces/contracts/vault/IProtocolFeeController.sol
#	pkg/vault/contracts/ProtocolFeeController.sol
#	pkg/vault/test/foundry/ProtocolFeeController.t.sol
Copy link
Contributor

@jubeira jubeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from fee-controller-script to main March 8, 2025 16:00
# Conflicts:
#	pkg/governance-scripts/contracts/ProtocolFeeControllerMigration.sol
Copy link
Contributor

@joaobrunoah joaobrunoah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EndymionJkb EndymionJkb merged commit e1ae7f0 into main Mar 11, 2025
16 checks passed
@EndymionJkb EndymionJkb deleted the registry-script branch March 11, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Governance script for BalancerContractRegistry
4 participants