Add initial global protocol fees to the ProtocolFeeController #1330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubeira
approved these changes
Mar 6, 2025
|
great job @EndymionJkb ! |
joaobrunoah
approved these changes
Mar 6, 2025
pkg/vault/contracts/VaultFactory.sol
Outdated
Comment on lines
114
to
115
| // If this passes, we know we can use the targetAddress for the vaultAddress. | ||
| if (targetAddress != getDeploymentAddress(salt)) { |
There was a problem hiding this comment.
Suggested change
| // If this passes, we know we can use the targetAddress for the vaultAddress. | |
| if (targetAddress != getDeploymentAddress(salt)) { | |
| // If this passes, we know we can use the targetAddress for the vaultAddress. | |
| if (targetAddress != getVaultDeploymentAddress(salt)) { |
Probably, if we change the function name, the comment is not needed.
There was a problem hiding this comment.
Yes; that's what I had to do to solve the stack-too-deep error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had a request to incorporate default fees into the protocol fee controller, so that we don't need to use governance to set them after deployment.
Another issue related to new chains is the fact that the Protocol Fee Controller used to be deployed with the Vault in the Vault factory. This means we'd have to redeploy the Vault factory every time we migrated the fee controller. To avoid this, we pass the fee controller address to the Vault factory, so that it can be deployed externally and these two deployments are decoupled.
Type of change
Checklist:
main, or there's a description of how to mergeIssue Resolution