This repository was archived by the owner on Oct 15, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like we are affected by this unresolved issue:
wevm/viem#1351
Passing undefined timeout works better in my last tests.
Note that I will keep
getWaitForReceiptTimeout(chainId: number)
function returning undefined to centralise the comment and to be able to change it in the future when we have more info.For now, I will monitor if this change reduces the Timeout errors in sentry (example)