Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

fix: USDT approval edge case #1152

Merged
merged 1 commit into from
Oct 7, 2024
Merged

fix: USDT approval edge case #1152

merged 1 commit into from
Oct 7, 2024

Conversation

agualis
Copy link
Contributor

@agualis agualis commented Oct 7, 2024

The edge case code was not working as expected. This PR fixes the tricky management of the double approval transaction isCompleted state with parallel hooks.

Can be tested impersonating with the user (0x6Ed0DEBC4C1b36aD558f2801a0F5a49B5a8BA08d) of this sentry error:
https://balancer-labs.sentry.io/issues/5737650083/?project=4506382607712256

@agualis agualis requested a review from garethfuller October 7, 2024 11:30
Copy link

vercel bot commented Oct 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 11:37am
test-v3 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 11:37am

@agualis agualis merged commit 78365e6 into main Oct 7, 2024
7 checks passed
@agualis agualis deleted the fix/usdtApproval branch October 7, 2024 13:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants