-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #41
Dev #41
Conversation
Feature/technologies
Reviewer's Guide by SourceryThis pull request introduces a new model called Technology and updates the str method of the existing Hobby model. The changes are focused on enhancing the portfolio application's data structure. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bartczak-pa - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
class Technology(models.Model): | ||
name = models.CharField(max_length=50, unique=True) | ||
|
||
class Meta: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Consider adding an ordering option in the Meta class
Adding an ordering option (e.g., ordering = ['name']) could be helpful for consistently displaying technologies in alphabetical order without additional sorting in views or templates.
class Meta:
verbose_name_plural = "Technologies"
ordering = ['name']
Closed - Missing migrations |
Summary by Sourcery
Add a new Technology model to the portfolio app and enhance the Hobby model by specifying the return type for its string representation method.
New Features:
Enhancements: