Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct referrer validation logic in IPFS avatar upload route #1683

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: correct referrer validation logic in IPFS avatar upload route #1683

wants to merge 2 commits into from

Conversation

Pistasha
Copy link

@Pistasha Pistasha commented Jan 31, 2025 •
edited
Loading

Description

What changed? Why?

  • Corrected typos in the variable name: from allowedReferersHost to allowedReferrersHost.
  • This is a minor cosmetic change that does not affect the logic or functionality.

Notes to reviewers

  • No changes have been made to the business logic; it’s purely a typo fix.

How has it been tested?

  • Verified that the project compiles and runs without any changes in behavior.

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2025 4:02pm

@vercel Vercel
Copy link

vercel bot commented Jan 31, 2025

@Pistasha is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 31, 2025 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@Pistasha Pistasha changed the title fix: rename useProvenWithdrawal hook and correct Synapse image URL fix: correct referrer validation logic in IPFS avatar upload route Jan 31, 2025
@wbnns wbnns added the base web review To be reviewed by the Base web team label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
base web review To be reviewed by the Base web team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Pistasha @cb-heimdall @wbnns