READY: Use well-known cipher list #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
changed the title
| @@ -157,9 +160,9 @@ RiakConnection.prototype._receiveHealthCheck = function(data) { | |||
|
|
|||
| RiakConnection.prototype._receiveStartTls = function(data) { | |||
| logger.debug("[RiakConnection]: receive StartTls response"); | |||
| this._connection.removeListener('data', this._boundReceiveStartTls); | |||
There was a problem hiding this comment.
So you are now removing the listener no matter what?
There was a problem hiding this comment.
It makes more sense to do it this way but there is no need to change this for just a bug fix. I'll revert it.
|
@lukebakken Had some problems setting up the cluster, so here's a tweak: basho/riak-client-tools#2 |
|
Works fine, now that I know the secret incantation |
|
👍 6aa7bf3 |
lukebakken
force-pushed
the
fixes/lrb/clients-640-cipher-list
branch
from
6aa7bf3 to
59bf8d4
Compare
lukebakken
force-pushed
the
fixes/lrb/clients-640-cipher-list
branch
from
59bf8d4 to
fc8b4b2
Compare
lukebakken
added a commit
that referenced
this pull request
Jan 16, 2016
READY: Use well-known cipher list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104 (CLIENTS-640)
To test:
devrelto use security:git clone git://github.com/basho/riak-client-tools cd riak-client-tools devrel/setup-dev-cluster -s -p PATH/TO/riak/devriak-nodejs-clientand, onmasterbranch:error.logfrom your first devrel node. You'll see the following:fixes/lrb/clients-640-cipher-listbranchgrunt securityand tests should pass