Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract title from .title[my title] #53

Merged
merged 2 commits into from
Dec 17, 2017
Merged

Conversation

arnfinn
Copy link

@arnfinn arnfinn commented Dec 11, 2017

Previously the HTML title was extracted from the first
occurrence of #. Thus, the HTML title was the title of
my second slide if I used .title for the first slide.

Please modify this pull request as you like:)

Arnfinn added 2 commits December 11, 2017 12:03
Previously the HTML title was extracted from the first
occurrence of #. Thus, the HTML title was the title of
my second slide if I used .title for the first slide.
@robertodr
Copy link
Contributor

Thanks! Do the test pass locally?

@bast
Copy link
Owner

bast commented Dec 11, 2017

Thanks! The broken test is "my" fault. This works locally but for some weird reason not on Travis. I need to redesign that test.

@bast
Copy link
Owner

bast commented Dec 11, 2017

I need to think a bit about this change. Background: the .title[] is a custom extension that we have defined. I am considering moving extensions to user space so that you can define them along your project and in this repo serve only vanilla render engines (currently remarkjs but I would also like to add reveal). It is a reasonable change in the current setting but please let me sleep on it ...

@arnfinn
Copy link
Author

arnfinn commented Dec 11, 2017

No problem @bast :)

@bast
Copy link
Owner

bast commented Dec 11, 2017

I will meditate over night and revisit this tomorrow and probably merge :-) Thanks a lot for contributing to this code!

@bast bast merged commit e0ca51f into bast:master Dec 17, 2017
@bast
Copy link
Owner

bast commented Dec 17, 2017

Merged. I think it makes sense in the current setup which might change in future but that's another story. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants