-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WORLDSERVICE-185: Replace uuid
with crypto.randomUUID
#12361
Draft
karinathomasbbc
wants to merge
24
commits into
latest
Choose a base branch
from
replace-uuid-with-crypto
base: latest
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,752
−1,629
Draft
Changes from 22 commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
b233534
Replace references of uuid with crypto.randomUUID
karinathomasbbc 8f08d12
Delete incorrect import
karinathomasbbc de463a6
Update test
karinathomasbbc 4f46031
Update bundle size :grimace:
karinathomasbbc b9e5cee
Fix tests
karinathomasbbc 69ab8a6
Use original mock value
karinathomasbbc 91078ec
Fix test
karinathomasbbc c91da53
Mocking of uuid
karinathomasbbc 4327214
Linting
karinathomasbbc 2d99a76
Fix test
karinathomasbbc 30c11e2
Mock UUID
karinathomasbbc b954f4e
Fix tests
karinathomasbbc f597b7c
Correct uuid format
karinathomasbbc dd526df
Correct uuid format
karinathomasbbc ce4cd80
Correct uuid format
karinathomasbbc c54d70b
Remove console log
karinathomasbbc 3899575
Fix test
karinathomasbbc 0409d58
Merge branch 'latest' of github.com:bbc/simorgh into replace-uuid-wit…
karinathomasbbc 33a3730
Enforce SSL encryption of cookie
karinathomasbbc be6ba53
Remove outdated package
karinathomasbbc ed45298
Increase bundle size
karinathomasbbc 19fd456
Mock optimizely in tests
karinathomasbbc 7310321
Merge branch 'latest' of github.com:bbc/simorgh into replace-uuid-wit…
karinathomasbbc 707bdfa
Fix tests
karinathomasbbc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file added
BIN
+6.76 MB
.yarn/cache/@img-sharp-libvips-darwin-arm64-npm-1.0.4-d0d063884a-10.zip
Binary file not shown.
Binary file removed
BIN
-6.74 MB
.yarn/cache/@img-sharp-libvips-linux-x64-npm-1.0.4-0974f077b7-10.zip
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,7 +11,6 @@ | |
"resolutions": { | ||
"@babel/runtime": "7.26.9", | ||
"@optimizely/js-sdk-utils": "0.4.0", | ||
"uuid": "3.4.0", | ||
"[email protected]": "patch:winston@npm:3.8.2#.yarn/patches/winston-npm-3.8.2-2035e9cac4.patch", | ||
"cookie": "0.7.1", | ||
"react-is": "19.0.0" | ||
|
@@ -129,7 +128,6 @@ | |
"react-router-dom": "5.3.4", | ||
"undici": "7.3.0", | ||
"url-parse": "1.5.10", | ||
"uuid": "8.3.2", | ||
"winston": "patch:[email protected]#./patches/winston-file-descriptor.patch" | ||
}, | ||
"devDependencies": { | ||
|
@@ -193,7 +191,6 @@ | |
"@types/react-router-dom": "5.3.3", | ||
"@types/testing-library__react": "10.2.0", | ||
"@types/url-parse": "^1.4.8", | ||
"@types/uuid": "^9.0.8", | ||
"@typescript-eslint/eslint-plugin": "5.62.0", | ||
"@typescript-eslint/parser": "8.24.0", | ||
"amphtml-validator": "1.0.38", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😬