-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WORLDSERVICE-420: Update manifest file for Public Service #12479
base: latest
Are you sure you want to change the base?
Conversation
Does this need updated as well? Line 130 in 1141690
Never really been sure what this route in the Express app actually does though. |
Ah... missed this, I'll take a look |
…morgh into WORLDSERVICE-420-ps-manifest-file
We now derive the manifest path from the service config, and only for WS services (the article & frontpage manifest regexes have been updated to include this) |
Update default service variants
…morgh into WORLDSERVICE-420-ps-manifest-file
Resolves JIRA https://jira.dev.bbc.co.uk/browse/WORLDSERVICE-420
Overall changes
Updates references to PS Manifest files
Code changes
Testing
Inspect HTML (search for manifest)
href should be https://static.files.bbci.co.uk/core/manifest.1ccdbcfd4cc3bf889128a50903c2b22c81758637.json
href should be /{service}/manifest.json (unchanged from equivalent page on bbc.com)
Check other services if desired
Helpful Links
Add Links to useful resources related to this PR if applicable.
Coding Standards
Repository use guidelines