Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WORLDSERVICE-420: Update manifest file for Public Service #12479

Open
wants to merge 21 commits into
base: latest
Choose a base branch
from

Conversation

karinathomasbbc
Copy link
Contributor

@karinathomasbbc karinathomasbbc commented Mar 6, 2025

@karinathomasbbc karinathomasbbc self-assigned this Mar 6, 2025
@karinathomasbbc karinathomasbbc marked this pull request as ready for review March 6, 2025 18:43
@amoore108
Copy link
Contributor

Does this need updated as well?

const manifestPath = `${__dirname}/public/${service}/manifest.json`;

Never really been sure what this route in the Express app actually does though.

@karinathomasbbc
Copy link
Contributor Author

Does this need updated as well?

const manifestPath = `${__dirname}/public/${service}/manifest.json`;

Never really been sure what this route in the Express app actually does though.

Ah... missed this, I'll take a look

@karinathomasbbc
Copy link
Contributor Author

Does this need updated as well?

We now derive the manifest path from the service config, and only for WS services (the article & frontpage manifest regexes have been updated to include this)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants