Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECHDEBT: Deprecate old CSV patterns #1487

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Feb 10, 2025

Description of Changes

  • Deprecates old CSV import files and utilities

Testing Notes

  • Note: I still need to manually test that everything is happy

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 58.13953% with 36 lines in your changes missing coverage. Please review.

Project coverage is 47.31%. Comparing base (ce549a6) to head (4e0f809).
Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...rvices/observation-services/observation-service.ts 13.04% 20 Missing ⚠️
...t-services/critter/utils/critter-header-configs.ts 57.14% 2 Missing and 4 partials ⚠️
...veys/animals/list/components/AnimalListToolbar.tsx 0.00% 6 Missing ⚠️
app/src/utils/csv-templates.ts 0.00% 2 Missing ⚠️
...import-services/critter/import-critters-service.ts 95.45% 1 Missing ⚠️
app/src/hooks/api/useSurveyApi.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1487      +/-   ##
==========================================
- Coverage   47.74%   47.31%   -0.44%     
==========================================
  Files         935      920      -15     
  Lines       25844    23822    -2022     
  Branches     3978     3536     -442     
==========================================
- Hits        12340    11271    -1069     
+ Misses      12848    11937     -911     
+ Partials      656      614      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MacQSL MacQSL added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Feb 10, 2025
@MacQSL MacQSL requested a review from NickPhura February 10, 2025 20:32
@MacQSL MacQSL changed the title TECHDEBT: Deprecated old CSV patterns TECHDEBT: Deprecate old CSV patterns Feb 11, 2025
Copy link

@MacQSL MacQSL added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant