Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TECHDEBT: Deprecate old CSV patterns #1487

Merged
merged 15 commits into from
Feb 24, 2025
Merged

TECHDEBT: Deprecate old CSV patterns #1487

merged 15 commits into from
Feb 24, 2025

Conversation

MacQSL
Copy link
Collaborator

@MacQSL MacQSL commented Feb 10, 2025

Description of Changes

  • Deprecates old CSV import files and utilities

Testing Notes

  • Note: I still need to manually test that everything is happy - Tested working

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 56.97674% with 37 lines in your changes missing coverage. Please review.

Project coverage is 47.45%. Comparing base (3dda7de) to head (b124bc2).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...rvices/observation-services/observation-service.ts 8.69% 21 Missing ⚠️
...t-services/critter/utils/critter-header-configs.ts 57.14% 2 Missing and 4 partials ⚠️
...veys/animals/list/components/AnimalListToolbar.tsx 0.00% 6 Missing ⚠️
app/src/utils/csv-templates.ts 0.00% 2 Missing ⚠️
...import-services/critter/import-critters-service.ts 95.45% 1 Missing ⚠️
app/src/hooks/api/useSurveyApi.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1487      +/-   ##
==========================================
- Coverage   47.57%   47.45%   -0.12%     
==========================================
  Files         926      920       -6     
  Lines       24182    24019     -163     
  Branches     3609     3582      -27     
==========================================
- Hits        11505    11399     -106     
+ Misses      12043    11990      -53     
+ Partials      634      630       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MacQSL MacQSL added the Early Feedback Welcome PR is not finished, but early review feedback is welcomed label Feb 10, 2025
@MacQSL MacQSL requested a review from NickPhura February 10, 2025 20:32
@MacQSL MacQSL changed the title TECHDEBT: Deprecated old CSV patterns TECHDEBT: Deprecate old CSV patterns Feb 11, 2025
@MacQSL MacQSL added Ready For Review PR is ready for review and removed Early Feedback Welcome PR is not finished, but early review feedback is welcomed labels Feb 13, 2025
Copy link

Copy link
Collaborator

@NickPhura NickPhura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried uploading some animals/measurements/markings, and observations. Also uploaded some device keys, in case. Seems happy.
Nice one!

🦕

@MacQSL MacQSL merged commit db44909 into dev Feb 24, 2025
22 of 23 checks passed
@MacQSL MacQSL deleted the mdTechdebt-csv-deprecate branch February 24, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready For Review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants