feat: #569 implement the redesign for dashboard and side nav #613
Conversation
craigyu
changed the title
frontend/src/App.tsx
Outdated
| @@ -46,6 +48,33 @@ const protectedRoutes: RouteObject[] = [ | |||
| } | |||
| ]; | |||
|
|
|||
| // Tanstack Query Config | |||
There was a problem hiding this comment.
Can we move this into a separate file?
| min-width: 1rem; | ||
| min-height: 1rem; | ||
| } | ||
| .divisory { |
There was a problem hiding this comment.
As the hr tag was removed from the template file, I think is safe to remove this css class from here as it is not being required anymore
There was a problem hiding this comment.
no there's still an hr element at line 48 😛
|
|
||
| .chart-holder { | ||
|
|
||
| .cds--cc--axes g.axis g.tick text { |
There was a problem hiding this comment.
Shouldn't we use the vars.$bcgov-prefix variable?
There was a problem hiding this comment.
the vars.$bcgov-prefix is 'bx', i think the prefix here is special for the chart component, honestly i didn't find this css having any effects, but left it here from the previous code
| { | ||
| !recentOpeningsQuery.isLoading && recentOpeningsQuery.data?.data.length ? | ||
| ( | ||
| <Table |
There was a problem hiding this comment.
One suggestion here would be to try to generify this table, something like this I am doing on another PR.
With a few changes on the headers object, we can even set if a specific field should use a component to render (such as the date, status, truncated texts). This would reduce code duplication, as we can just provide to the data table the page content, pagination content and possible empty scenario flags/texts
There was a problem hiding this comment.
yeah that's a good idea, it might be better to do it in a separate issue, then we can have all tables to use the generic table with loading and error handling
Description
Implements #569
Implemented the new design for dashboard and and side nav
Type of change
Please delete options that are not relevant.
ick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc... -->
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: