fix(602): fixing submission trend request #619
+42
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
3 tasks
craigyu
approved these changes
Feb 15, 2025
|
|
||
| // Generate the DTOs in the custom order | ||
| return yearMonths.stream() | ||
| .map(yearMonth -> new OpeningsPerYearDto( | ||
| yearMonth.getMonthValue(), | ||
| yearMonth.getYear(), | ||
| getMonthName(yearMonth.getMonthValue()), |
There was a problem hiding this comment.
I think the month name can be omitted, either here or in future endpoints, it's something front end can do quite well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with the submission trends that happened during the aggregation phase, where the backend application was using all of the available resources to do the aggregation.
Fixes #602
Type of change
How Has This Been Tested?
Checklist
Further comments
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in:
Thanks for the PR!
Deployments, as required, will be available below:
Please create PRs in draft mode. Mark as ready to enable:
After merge, new images are deployed in: