Fix Reporting Service #2218
Merged
Fix Reporting Service #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
commented
Aug 27, 2024
| @@ -217,7 +217,7 @@ public async Task<IActionResult> SendToAsync(int id, string to) | |||
| var username = User.GetUsername() ?? throw new NotAuthorizedException("Username is missing"); | |||
| var user = _userService.FindByUsername(username) ?? throw new NotAuthorizedException($"User [{username}] does not exist"); | |||
|
|
|||
| var request = new ReportRequestModel(ReportDestination.ReportingService, Entities.ReportType.Content, report.Id, new { }) | |||
| var request = new ReportRequestModel(ReportDestination.ReportingService, Entities.ReportType.Content, report.Id, JsonDocument.Parse("{}")) | |||
There was a problem hiding this comment.
Needed to change to JsonDocument because it was being used inconsistently with a dynamic object.
| JsonValueKind.String => !typeof(T).IsEnum ? | ||
| (T)Convert.ChangeType($"{node.GetString()}".Trim(), typeof(T)) : | ||
| (T)Enum.Parse(typeof(T), node.GetString() ?? ""), | ||
| JsonValueKind.String => ((Func<T?>)(() => |
There was a problem hiding this comment.
Fixed parsing issue with nullable enum values
| /// Get the preferred email if it has been set. | ||
| /// </summary> | ||
| /// <returns></returns> | ||
| public string[] GetEmails() |
| @@ -182,7 +182,7 @@ public override async Task RunAsync() | |||
| // Reached limit return to ingest manager, send email. | |||
| if (manager.Ingest.FailedAttempts >= manager.Ingest.RetryLimit) | |||
| { | |||
| await this.SendEmailAsync($"Ingest [{ingest.Name}] failed. Reached [{manager.Ingest.RetryLimit}] maximum retries.", ex); | |||
| await this.SendErrorEmailAsync($"Ingest [{ingest.Name}] failed. Reached [{manager.Ingest.RetryLimit}] maximum retries.", ex); | |||
There was a problem hiding this comment.
Renamed method to make it clear
| @@ -7,5 +7,5 @@ public enum ReportingErrors | |||
| FailedToAddInstance = 2, | |||
| FailedToUpdateInstance = 3, | |||
| FailedToGenerateOutput = 4, | |||
| FailedToEmail = 4, | |||
| FailedToEmail = 5, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Reporting Service can now be configured to resend on failures, and whether it will attempt to send the report to every subscriber before it logs the report send as a failure. This provides a way to get a report out to subscribers when only a single subscriber's email is failing.
Summary
Reporting Service Configuration Options