Fix charts #2228
Merged
Fix charts #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosol
added
bug
Publish tno-core:0.1.141
Fosol
commented
Aug 29, 2024
| @@ -65,10 +65,12 @@ export const ReportSectionMediaAnalyticsChart = React.forwardRef< | |||
| return ( | |||
| <Col key={chart.id} className="chart"> | |||
| <Row className="chart-header"> | |||
| <Col flex="1"> | |||
| <Col flex="1" onClick={() => setShowConfig((show) => !show)}> | |||
There was a problem hiding this comment.
Show/Hide chart by clicking on header.
| @@ -99,15 +105,15 @@ export const ChartPicker: React.FC<IChartSectionProps> = ({ sectionIndex, chartI | |||
|
|
|||
| <Col className="frm-in"> | |||
| <label>Axis</label> | |||
| <FormikCheckbox | |||
| <Checkbox | |||
There was a problem hiding this comment.
Fixed issue with isHorizontal because it's the opposite of the checkbox label.
|
|
||
| const canvasRef = React.useRef<HTMLCanvasElement>(null); | ||
|
|
||
| const section = values.sections[sectionIndex]; | ||
| const chart = section.chartTemplates[chartIndex]; | ||
| const uid = `${section.id}_${sectionIndex}`; | ||
|
|
||
| React.useEffect(() => { |
There was a problem hiding this comment.
Auto resize the chart based on axis values. However, this only works if the user opens the chart section.
| if (a > b) return 1; | ||
| return 0; | ||
| }); | ||
| options.groups?.map((g) => ({ key: g, label: `${g}` })) ?? |
There was a problem hiding this comment.
Fixed sorting and alignment of values to labels.
| "series" => content.GroupBy(c => c.SeriesId?.ToString() ?? "NA").OrderBy(group => group.Key).Where((g) => !excludeEmptyValues || g.Key != "NA"), | ||
| "sentiment" => content.GroupBy(c => GetSentimentValue(c)?.ToString() ?? "null").Where((v) => !excludeEmptyValues || v.Key != "null").OrderByDescending(group => group.Key), | ||
| "sentimentSimple" => content.GroupBy(c => GetSentimentRating(c) ?? "null").Where((v) => !excludeEmptyValues || v.Key != "null").OrderBy(group => group.Key), | ||
| "series" => content.GroupBy(c => c.Series?.Name ?? c.OtherSeries ?? "None").Where((g) => !excludeEmptyValues || g.Key != "None").OrderBy(group => group.Key), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing chart configuration options and display.
Added ability to auto resize the chart. This does not work for auto reports yet.
Summary
Subscriber Report Charts