Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEVSU-2575 IPR API Search Rework #436

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

DEVSU-2575 IPR API Search Rework #436

wants to merge 8 commits into from

Conversation

bnguyen-bcgsc
Copy link
Contributor

@bnguyen-bcgsc bnguyen-bcgsc commented Mar 18, 2025 •
edited
Loading

  • DEVSU-2575 & DEVSU-2533 & DEVSU-2493
  • Rework search to take search parameters dynamically and search for reports that fit multiple search criteria at the same time
  • Optimize search speed and front page loading speed
  • Update report unit test

@bnguyen-bcgsc
- DEVSU-2575
abd446e 
- Rework search to take search parameters dynamically and search for reports that fit multiple search criteria at the same time
@bnguyen-bcgsc
- Update report test with correct search syntax
f7f8770 
- Include keyVariant and kbVariant models
@bnguyen-bcgsc
- Delete temporary fuzzy search util library file
a9eac4d
@bnguyen-bcgsc
- Update dynamic fuzzy search util library to accommodate more search…
338439e 
… categories

- Optimize eager loading performance by adding 'foreignKeyConstraint' to hasMany associations and 'separate' to includes
- Code lint
@bnguyen-bcgsc
- Remove separate true for reportUser model include when role param
266232d
@bnguyen-bcgsc
- Remove unnecessary foreignKeyConstraints in various associations
cb7b707
@bnguyen-bcgsc bnguyen-bcgsc added the enhancement New feature or request label Mar 18, 2025
@bnguyen-bcgsc bnguyen-bcgsc self-assigned this Mar 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 82.75862% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.19%. Comparing base (71777bb) to head (1052590).

Files with missing lines Patch % Lines
app/libs/fuzzySearch.js 80.00% 8 Missing and 2 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #436      +/-   ##
===========================================
+ Coverage    77.18%   77.19%   +0.01%     
===========================================
  Files          179      180       +1     
  Lines         6135     6183      +48     
  Branches       714      727      +13     
===========================================
+ Hits          4735     4773      +38     
- Misses        1323     1331       +8     
- Partials        77       79       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elewis2 elewis2 Awaiting requested review from elewis2

@sshugsc sshugsc Awaiting requested review from sshugsc

At least 1 approving review is required to merge this pull request.

Assignees

@bnguyen-bcgsc bnguyen-bcgsc

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bnguyen-bcgsc @codecov-commenter