Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored duplicate hash related code in tx.js and abstractblock.js #1130

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haxwell
Copy link

@haxwell haxwell commented Jan 19, 2023

DRYed up some duplicate code. Moved common hash related code from tx.js and abstractblock.js to a new parent class defined in hasHashBehavior.js.

@haxwell haxwell changed the title Refactored duplicate hash() implementations in tx.js and block.js Refactored duplicate hash related code in tx.js and abstractblock.js Jan 19, 2023
@haxwell
Copy link
Author

haxwell commented Jan 29, 2023

@pinheadmz Can I get a review on this? If not from you, another knowledgeable person.. Thanks :)

@haxwell
Copy link
Author

haxwell commented Jan 29, 2023

@masterchief164 Thanks for the offer to do a review.. I know your time is limited, so please do this one first! Thank you...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant