Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wallet HD paths to JSON received from create TX #1131

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pinheadmz
Copy link
Member

@pinheadmz pinheadmz commented Jan 26, 2023

This is a backport of handshake-org/hsd#145 and handshake-org/hsd#802 from hsd. It adds wallet paths in the JSON from creating transactions so external signers can derive the right private keys, and also inform the user about the total balance from a tx.

boymanjor and others added 6 commits January 26, 2023 09:40
This commit includes a new class WalletCoinView and a helper
class Paths. WalletCoinView inherits from CoinView and adds
the ability to store HD paths on coin viewpoint objects.
This commit exposes a new 'network' argument to `toPath`. Passing
the network type will generate a full HD path instead of the current,
abbreviated path.
also clean up backports form hsd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants