Add RELEASETYPE mapping for albumtype and RELEASESTATUS mapping for albumstatus #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…albumstatus MediaField
|
Nice! This seems good to me. Would you mind adding a quick note to the changelog? |
|
I updated the changelog. Is that fine? |
|
Looks great; thanks again!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Picard tag mappings documentation, the "Release Status" tag is mapped to
MUSICBRAINZ_ALBUMSTATUSfor APEv2 andRELEASESTATUSfor Vorbis comments and the "Release Type" tag is mapped toMUSICBRAINZ_ALBUMTYPEfor APEv2 andRELEASETYPEfor Vorbis comments.Currently, mediafile only reads and writes
MUSICBRAINZ_ALBUMSTATUSinalbumstatusfor Vorbis comments and APEv2, so it doesn't pick up the value in FLAC files edited with Picard.Same thing for
albumtype,RELEASETYPEshould be supported alongsideMUSICBRAINZ_ALBUMTYPE.