Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list fields will now return None if the tag does not exist #64

Merged
merged 2 commits into from
Nov 26, 2022
Merged

list fields will now return None if the tag does not exist #64

merged 2 commits into from
Nov 26, 2022

Conversation

jtpavlock
Copy link
Contributor

@jtpavlock jtpavlock commented Oct 20, 2022 •
edited
Loading

Fixes #63

@jtpavlock jtpavlock marked this pull request as draft October 20, 2022 18:55
@jtpavlock jtpavlock marked this pull request as ready for review October 23, 2022 20:28
@jtpavlock jtpavlock requested a review from sampsyo October 23, 2022 20:29
@jtpavlock jtpavlock force-pushed the master branch 3 times, most recently from 6e9d282 to 690a041 Compare October 23, 2022 20:41
@jtpavlock
Copy link
Contributor Author

@sampsyo I know you're busy, but is there anything else I can do to help get this reviewed/merged?

sampsyo
sampsyo approved these changes Nov 26, 2022
View reviewed changes
Copy link
Member

@sampsyo sampsyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your patience!! This all looks good from here.

@sampsyo sampsyo merged commit 117f51a into beetbox:master Nov 26, 2022
sampsyo added a commit that referenced this pull request Nov 26, 2022
@sampsyo
Changelog entry for #64
892e7df
@jtpavlock
Copy link
Contributor Author

Thanks for merging this in! Any chance you could cut a release with this fix?

@sampsyo
Copy link
Member

sampsyo commented Dec 15, 2022 •
edited
Loading

Done! https://pypi.org/project/mediafile/0.11.0/

@wisp3rwind wisp3rwind mentioned this pull request Dec 17, 2022
Closed
wisp3rwind added a commit to wisp3rwind/beets that referenced this pull request Dec 18, 2022
@wisp3rwind
tests: fix assertions for empty MediaFile.images
d5f998b 
used to work due to inconsistent mediafile implementation, but with
beetbox/mediafile#64 (in mediafile >= 0.11.0)
list fields are None if non-existent, not the empty list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sampsyo sampsyo sampsyo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List fields don't return None if the tag doesn't exist
2 participants
@jtpavlock @sampsyo