Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add processing of .pth files from "app_packages". #72

Merged

Conversation

timrid
Copy link
Contributor

@timrid timrid commented Mar 22, 2025

As described here, the app_packages should be added via site.addsitedir() so that .pth files are executed correctly.

I tested it with a minimal example project I made for this: pth-execution-checker

Should fix beeware/briefcase#2195, beeware/briefcase#669 and beeware/briefcase#381 for "macos xcode".

There are also a similar PRs for:

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome - works great in my testing. As with with VisualStudio PR, waiting until we're ready to merge all the templates before merging this one.

The pth-execution-checker was a really helpful test utility as well. That code would be a really good candidate for including in the Python-support-testbed project as a way to validate that the templates and support packages are all working together as expected.

@timrid
Copy link
Contributor Author

timrid commented Mar 24, 2025

That was the intention of pth-execution-checker to be included as test case in the Python-support-testbed. Feel free to fork or copy it to a repo under the beeware organization, so you dont have a dependency to a "foreign" repo, that is not under your control.

@freakboy3742 freakboy3742 merged commit 1917638 into beeware:main Mar 25, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use site-packages folder instead of app and app_packages
2 participants