Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to ESM #123

Closed
wants to merge 36 commits into from
Closed

Convert to ESM #123

wants to merge 36 commits into from

Commits on Apr 23, 2024

  1. checkpoint: partial implentation of esm

    @begin-again
    begin-again committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    bb3cf2f View commit details
    Browse the repository at this point in the history

  2. temp

    @begin-again
    begin-again committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7aefdb8 View commit details
    Browse the repository at this point in the history

  3. replace temp module with temp class

    @begin-again
    begin-again committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    7bb523e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. common/repos: remove getBinaryPaths

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4a6c5ed View commit details
    Browse the repository at this point in the history

  2. common/engine: constructor tests

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6480c5d View commit details
    Browse the repository at this point in the history

  3. progress

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    ac57ee2 View commit details
    Browse the repository at this point in the history

  4. more progress

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    6af918d View commit details
    Browse the repository at this point in the history

  5. remove old spec

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2ffb4b1 View commit details
    Browse the repository at this point in the history

  6. update .mocha.yml to use js

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    775a5a2 View commit details
    Browse the repository at this point in the history

  7. osType is a function

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    a6f66a2 View commit details
    Browse the repository at this point in the history

  8. rename yarn/index to js

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    324f87f View commit details
    Browse the repository at this point in the history

  9. rename setup to js

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    2c2c52b View commit details
    Browse the repository at this point in the history

  10. engine: allInstalledNodeVersions test bug fix 

    Seems the mock-fs library does not mock fs.existsSync which caused tests
 to fail.

Instead of using existsSync to verify nodeHome, utilize a direectory
read of the parent of nodeHome and if found there and is a directory
that's good enough.
    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    076d9cb View commit details
    Browse the repository at this point in the history

  11. upgrades dependencies 

    Except that chai must stay at v4 for sinon-chai-es.
    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    df4babb View commit details
    Browse the repository at this point in the history

  12. fixed derfault param on versionToUseValidator

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    d8f4806 View commit details
    Browse the repository at this point in the history

  13. spawners: use process.stdout.write

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    7cc7079 View commit details
    Browse the repository at this point in the history

  14. add not about testing

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    1e36f06 View commit details
    Browse the repository at this point in the history

  15. commit changes to lock file

    @begin-again
    begin-again committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    9e2f3c7 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Update README.md 

    remove excessive blank lines

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @begin-again @coderabbitai
    begin-again and coderabbitai[bot] authored Jun 22, 2024
    Configuration menu
    Copy the full SHA
    0281b6b View commit details
    Browse the repository at this point in the history

  2. Update src/common/net.js 

    fix typo

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @begin-again @coderabbitai
    begin-again and coderabbitai[bot] authored Jun 22, 2024
    Configuration menu
    Copy the full SHA
    db5f265 View commit details
    Browse the repository at this point in the history

  3. chore: Improve error handling in engines.js 

    This commit improves the error handling in the `engines.js` file. Instead of throwing an error, it now logs an error message and exits the process with a non-zero status code when the `package.json` file is not found. This change ensures better user experience and provides more informative error messages.

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
    @begin-again @coderabbitai
    begin-again and coderabbitai[bot] committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    98f495c View commit details
    Browse the repository at this point in the history

  4. chore: Refactor engine.js for better readability 

    This commit refactors the `engine.js` file to improve code readability. Specifically, it updates the `allInstalledNodeVersions` method to handle cases where the `NVM_BIN` or `NVM_HOME` environment variables are not defined.

use optional chaining were feasible
    @begin-again
    begin-again committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    e9fb1c8 View commit details
    Browse the repository at this point in the history

  5. split mocked FS by os

    @begin-again
    begin-again committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    9a677b0 View commit details
    Browse the repository at this point in the history

  6. ensure mocked fs is restored after tests

    @begin-again
    begin-again committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    3e14075 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. misc changes

    @begin-again
    begin-again committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e27347c View commit details
    Browse the repository at this point in the history

  2. remove play

    @begin-again
    begin-again committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    885a2b1 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. remove package 'dev'

    @begin-again
    begin-again committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8a52718 View commit details
    Browse the repository at this point in the history

  2. fixes for type problems

    @begin-again
    begin-again committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    3da9ca4 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2024

  1. yarn upgrade to 4.3.1

    @begin-again
    begin-again committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3e371df View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. linting fixes

    @begin-again
    begin-again committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d825bcc View commit details
    Browse the repository at this point in the history

  2. sync master

    @begin-again
    begin-again committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    9213d34 View commit details
    Browse the repository at this point in the history

  3. more lint/type fixes

    @begin-again
    begin-again committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    e747cc0 View commit details
    Browse the repository at this point in the history

  4. sync master yet again

    @begin-again
    begin-again committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    8eb7269 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. use v9 eslint

    @begin-again
    begin-again committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    b2d2a8f View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2024

  1. add types for node and mocha; upgrade deps

    @begin-again
    begin-again committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    6030eea View commit details
    Browse the repository at this point in the history

  2. refactor versionStringToNumber for readability

    @begin-again
    begin-again committed Oct 5, 2024
    Configuration menu
    Copy the full SHA
    430f7a0 View commit details
    Browse the repository at this point in the history