This repository has been archived by the owner on Aug 1, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeti-or
force-pushed
the
yeti-or.bem-cell
branch
from
January 24, 2017 05:15
923902d
to
1a4f7e3
Compare
If you noticed I didn't break API cause this package is already
var path = require('@bem/path')('nested');
path.resolve(new BemCell({
entity: new BemEntityName({
block: 'a',
elem: 'e1'
}),
tech: 'js',
layer: 'common.blocks'
})
); |
or even: var path = require('@bem/path');
path.resolve(new BemCell({
entity: new BemEntityName({
block: 'a',
elem: 'e1'
}),
tech: 'js'
})
);
path.flat().resolve(new BemCell({
entity: new BemEntityName({
block: 'a',
elem: 'e1'
}),
tech: 'js'
})
); |
skad0
approved these changes
Jan 24, 2017
skad0
reviewed
Jan 24, 2017
@@ -3,31 +3,22 @@ var path = require('path'), | |||
bemNaming = require('bem-naming'); | |||
|
|||
module.exports = { | |||
path: function(entity, tech, options) { | |||
path: function(cell, options) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should throw an exception if there isn't BemCell?
Yeti-or
force-pushed
the
yeti-or.bem-cell
branch
from
January 24, 2017 14:24
82c926c
to
671b420
Compare
@skad0 add assertion |
skad0
approved these changes
Jan 25, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closing #10
Example of new API:
options for
bem-naming
could be passed as second argument: