Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for bem-config and support for latest bem-walker #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MrKashlakov
Copy link

Проблемы две:

  • Сейчас в коде поддержана сарая версия bem-config и код не может работать с текущей версией bem-config. Поддерживать новое API смысла нет, так как оно активно меняется и дорабатывается. Предлагаю пока сделать такое решение.
  • После обновления bem-walker формат BEM Entity изменился, реалзовал метод поддерживающий новый формат BEM Entity.

@coveralls
Copy link

coveralls commented Jul 3, 2016

Coverage Status

Coverage decreased (-2.9%) to 95.522% when pulling 1e02782 on MrKashlakov:dev into 498eb8a on bem-contrib:master.

@MrKashlakov MrKashlakov changed the title Default for bem-config and support for latest bet-walker Default for bem-config and support for latest bem-walker Jul 3, 2016
@coveralls
Copy link

coveralls commented Jul 3, 2016

Coverage Status

Coverage decreased (-2.9%) to 95.522% when pulling 7ca38b1 on MrKashlakov:dev into 498eb8a on bem-contrib:master.

@coveralls
Copy link

coveralls commented Jul 4, 2016

Coverage Status

Coverage increased (+1.5%) to 100.0% when pulling 6ab90b6 on MrKashlakov:dev into 498eb8a on bem-contrib:master.

@@ -94,8 +95,16 @@ exports.getFiltersForConditions = function(conditions) {
return new Filter(criteria);
}),
apply = function(item) {
// Prepare BEM entity for check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

давайте просто использовать новый формат везде вместо трансформаций?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Поправил тут: bf333b9

@coveralls
Copy link

coveralls commented Jul 4, 2016

Coverage Status

Coverage remained the same at 98.462% when pulling bf333b9 on MrKashlakov:dev into 498eb8a on bem-contrib:master.

block: 'foo',
entity: {
block: 'foo'
},
elem: 'baz'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Очень странно, почему блок в энтити, а елем отдельно?

@Yeti-or
Copy link

Yeti-or commented Oct 28, 2016

any progress here?

@a-x-
Copy link
Member

a-x- commented Nov 17, 2016

ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants