Performance #24
Closed
Performance #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extract grid specificities into the Graph function (thus replace `grid` parameter to a `graph`object) - Regroup heuristics functions under astar.heuristics - Update tests, benchmark & demo - Added a specific test to demonstrate non-grid layout usage with a gps heuristic
- Only use one var when possible - Define one var on each line (child1N) - Avoid comments on 2 lines for a few chars - Remove unecessary empty lines
- Optimize with .join rather than lots of string concatenations - Add comment to specify that .toString() only work in grid layout mode
Performance API is more precise https://developer.mozilla.org/en-US/docs/Web/API/Performance http://updates.html5rocks.com/2012/08/When-milliseconds-are-not-enough-performance-now Note: I did not switch new Date().getTime() to Date.now() because it only works with IE>8. But this might be interesting because Date.now() is faster than new Date().getTime() (no object creation). http://stackoverflow.com/questions/12517359/performance-date-now-vs-date-gettime
This small optimization avoid to redefine the pathTo function in memory each time astar.search() is called.
|
Looks like this includes commits from #21 - you will need to rebase this - you may consider just opening a new PR based off of master |
Closed
|
Will do another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Performance API if available + optimize astar.search by moving pathTo function outside