Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

327 create a method to query which version of lcf an endpoint implements #333

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

anthonywhitford
Copy link
Collaborator

This PR includes all the changes for Issue 327, introducing the new LCF VERSION entity, E16, and removing the /1.0/ from within the REST implementation standard. The new LcfVersion XML entity within the schema does not extend the default LcfEntity, as there is no requirement for an as this is a statement of a version, not an entity row in a table of data.

This is a breaking change - so this should be in LCF 1.4.x rather than a patch for 1.3

Copy link
Collaborator

@franciscave franciscave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, apart from some possible inconsistencies in changes to LCF version numbers. See comments on individual file changes.

docs/LCF-DataFrameworks.md Show resolved Hide resolved
docs/LCF-RESTWebServiceSpecification.md Show resolved Hide resolved
Copy link
Collaborator

@franciscave franciscave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a method to query which version of LCF an endpoint implements
2 participants