-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
327 create a method to query which version of lcf an endpoint implements #333
Open
anthonywhitford
wants to merge
9
commits into
develop
Choose a base branch
from
327-create-a-method-to-query-which-version-of-lcf-an-endpoint-implements
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
327 create a method to query which version of lcf an endpoint implements #333
anthonywhitford
wants to merge
9
commits into
develop
from
327-create-a-method-to-query-which-version-of-lcf-an-endpoint-implements
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscave
requested changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, apart from some possible inconsistencies in changes to LCF version numbers. See comments on individual file changes.
franciscave
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes all the changes for Issue 327, introducing the new LCF VERSION entity, E16, and removing the /1.0/ from within the REST implementation standard. The new LcfVersion XML entity within the schema does not extend the default LcfEntity, as there is no requirement for an as this is a statement of a version, not an entity row in a table of data.
This is a breaking change - so this should be in LCF 1.4.x rather than a patch for 1.3