BIP374: Add message to rand computation #1758
Open
+36
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewtoth
force-pushed
the
bip374-message
branch
from
9a4d124 to
27d4d38
Compare
|
This might be a good point to introduce a Changelog? |
@andrewtoth would you like to add a changelog here? I suppose an editor can add one if you prefer. |
|
@jonatack @murchandamus I've added a changelog section. |
jonatack
reviewed
Feb 25, 2025
| @@ -118,6 +118,12 @@ This proposal is compatible with all older clients. | |||
| A reference python implementation is included [https://github.com/bitcoin/bips/blob/master/bip-0374/reference.py here]. | |||
| Test vectors can be generated by running <code>./bip-0374/gen_test_vectors.py</code> which will produce a CSV file of random test vectors for both generating and verifying proofs. These can be run against the reference implementation with <code>./bip-0374/run_test_vectors.py</code>. | |||
|
|
|||
| == Changelog == | |||
|
|
|||
| To help implementors understand updates to this BIP, we keep a list of substantial changes. | |||
There was a problem hiding this comment.
s/implementors/implementers/ (see #1766)
(or simply drop this line)
|
|
||
| * 0.2.0 (2025-02): | ||
| ** Add the message to the rand computation | ||
| * 0.1.0 (2024-12): |
There was a problem hiding this comment.
Suggested change
| * 0.1.0 (2024-12): | |
| * 0.1.0 (2024-12-26): |
|
|
||
| To help implementors understand updates to this BIP, we keep a list of substantial changes. | ||
|
|
||
| * 0.2.0 (2025-02): |
There was a problem hiding this comment.
Maybe the date of opening this PR, or the current date of the latest push.
Suggested change
| * 0.2.0 (2025-02): | |
| * 0.2.0 (2025-02-25): |
| @@ -73,12 +73,12 @@ The algorithm ''GenerateProof(a, B, r, G, m)'' is defined as: | |||
| * Let ''A = a⋅G''. | |||
| * Let ''C = a⋅B''. | |||
| * Let ''t'' be the byte-wise xor of ''bytes(32, a)'' and ''hash<sub>BIP0374/aux</sub>(r)''. | |||
| * Let ''rand = hash<sub>BIP0374/nonce</sub>(t || cbytes(A) || cbytes(C))''. | |||
| * Let ''m' = m if m is provided, otherwise an empty byte array''. | |||
| * Let ''rand = hash<sub>BIP0374/nonce</sub>(t || cbytes(A) || cbytes(C) || m')''.<ref name="why_include_m_in_rand"> ''' Why include the message in the rand computation?''' Not including the message in the rand compution could leak ''a'' if two proofs were constructed for the same ''a'', ''B'', and ''G'' but different ''m'' and all-zero ''r''.</ref> | |||
There was a problem hiding this comment.
Suggested change
| * Let ''rand = hash<sub>BIP0374/nonce</sub>(t || cbytes(A) || cbytes(C) || m')''.<ref name="why_include_m_in_rand"> ''' Why include the message in the rand computation?''' Not including the message in the rand compution could leak ''a'' if two proofs were constructed for the same ''a'', ''B'', and ''G'' but different ''m'' and all-zero ''r''.</ref> | |
| * Let ''rand = hash<sub>BIP0374/nonce</sub>(t || cbytes(A) || cbytes(C) || m')''.<ref name="why_include_m_in_rand"> ''' Why include the message in the rand computation?''' Not including the message in the rand compution could leak ''a'' if two proofs were constructed for the same ''a'', ''B'', and ''G'' but a different message ''m'' and an all-zero ''r''.</ref> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the message in the rand computation to avoid leaking
aas described here.