Merge #113: Disallow empty blocks response

340cd1c fix(client): disallow empty blocks response (Rob N)

Pull request description:

  This is my first attempt at resolving the empty blocks response at the client level. I didn't find that any of the current error variants accurately described the problem, but could use some outside opinions

  @oleonardolima @notmandatory

ACKs for top commit:
  ValuedMammal:
    ACK 340cd1c
  oleonardolima:
    utACK 340cd1c

Tree-SHA512: fc79b40fc499727d0061142d6906ae3b1f1672c507181c0c86d9527afdcdaea82e8b0e8af64a7e2463e3f4ed84595d666e854fe97d070a900cfe5a10d25b4af8

src/async.rs

@@ -442,7 +442,11 @@ impl<S: Sleeper> AsyncClient<S> {
             Some(height) => format!("/blocks/{height}"),
             None => "/blocks".to_string(),
         };
-        self.get_response_json(&path).await
+        let blocks: Vec<BlockSummary> = self.get_response_json(&path).await?;
+        if blocks.is_empty() {
+            return Err(Error::InvalidResponse);
+        }
+        Ok(blocks)
     }
 
     /// Get the underlying base URL.

src/blocking.rs

@@ -370,7 +370,11 @@ impl BlockingClient {
             Some(height) => format!("/blocks/{}", height),
             None => "/blocks".to_string(),
         };
-        self.get_response_json(&path)
+        let blocks: Vec<BlockSummary> = self.get_response_json(&path)?;
+        if blocks.is_empty() {
+            return Err(Error::InvalidResponse);
+        }
+        Ok(blocks)
     }
 
     /// Sends a GET request to the given `url`, retrying failed attempts

src/lib.rs

@@ -225,6 +225,8 @@ pub enum Error {
     InvalidHttpHeaderName(String),
     /// Invalid HTTP Header value specified
     InvalidHttpHeaderValue(String),
+    /// The server sent an invalid response
+    InvalidResponse,
 }
 
 impl fmt::Display for Error {