Fix transaction version field not properly serialized #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Armss9936
approved these changes
Jan 25, 2025
andrewtoth
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
ACK
Since bitcoin/bitcoin#29325 it is stored in bitcoind as a uint32_t, and now in Bitcoin Core v28 the JSON-RPC response returns it as an unsigned 32 bit integers. This makes transactions c659729a7fea5071361c2c1a68551ca2bf77679b27086cc415adeeb03852e369 and 35e79ee733fad376e76d16d1f10088273c2f4c2eaba1374a837378a88e530005 fail to parse.
andrewtoth
suggested changes
Feb 12, 2025
There was a problem hiding this comment.
Actually, this line needs to be updated to use writeUInt32 as well.
Armss9936
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The transaction's version is serialized as an int, instead of uint, disallowing serializing transactions with versions >0x80000000 and allowing serializing transactions with negative version field.