Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prerelease v-9.4.2-pre-01 (#9865) #9879

Merged

Conversation

msynk
Copy link
Member

@msynk msynk commented Feb 12, 2025

closes #9865

Summary by CodeRabbit

  • Chores
    • Updated version numbers across multiple packages and modules to 9.4.2-pre-01.
  • Documentation
    • Revised installation instructions and displayed version details to match the new release.
  • Refactor
    • Adjusted configuration comments and streamlined version references throughout the project.

These updates standardize the versioning across the platform and provide clearer guidance for installation while maintaining consistent functionality.

@msynk msynk requested a review from ysmoradi February 12, 2025 15:34
Copy link

coderabbitai bot commented Feb 12, 2025

Walkthrough

This pull request updates the versioning across the repository from 9.4.1 to 9.4.2-pre-01. The changes include version assignments in JavaScript/TypeScript modules, package references in various project files, version comments in service worker scripts, and updated installation instructions in template files. Additionally, one service worker file now has several caching and event listener sections commented out. No modifications were made to core functionality or control flow beyond these version and minor configuration updates.

Changes

File(s) Change Summary
src/Besql/Bit.Besql/wwwroot/bit-besql.js, src/BlazorUI/Bit.BlazorUI/Scripts/general.ts, src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts, .../bit-bswup.sw.ts, .../bit-bswup.ts, src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts, .../bit-bup.ts, src/Butil/Bit.Butil/Scripts/butil.ts Updated version properties from 9.4.1 to 9.4.2-pre-01.
src/Bit.Build.props, various .csproj files (e.g., .../Bit.BlazorUI.Demo.*.csproj, .../Bit.BlazorEmpty/*, src/Websites/**), and directory configuration files (Directory.Packages.props, Directory.Packages8.props, Directory.Build.props) Updated package references, version properties, and template version comments from 9.4.1 to 9.4.2-pre-01; adjustments include minor asset inclusion changes (e.g., removal of a launchSettings.json entry).
Service worker scripts (e.g., .../wwwroot/service-worker.published.js in BlazorUI, Bswup, FullDemo, and Boilerplate projects) Updated version comments from 9.4.1 to 9.4.2-pre-01; in one file, several service worker event and caching logic sections were commented out.
src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor and its code-behind Revised installation instructions and command snippets to reference Bit.Boilerplate version 9.4.2-pre-01.

Sequence Diagram(s)

sequenceDiagram
    participant B as Browser
    participant SW as Service Worker
    B->>SW: Register Service Worker (v9.4.2-pre-01)
    SW-->>B: Acknowledge registration
    B->>SW: Trigger "install" event
    Note right of SW: (Caching logic commented out)
    SW-->>B: Complete install
    B->>SW: Trigger "activate" event
    SW-->>B: Complete activation
    B->>SW: Trigger "fetch" event
    SW-->>B: Default network response
Loading

Poem

I'm a happy rabbit, leaping with delight,
Upgrading my code from day to night.
From 9.4.1 to pre-release so new,
Each version bump hops my spirit through.
With a twitch of my nose and a joyful hop,
I celebrate these changes non‐stop!
🐇✨

✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bdd63d9 and 17987ad.

📒 Files selected for processing (43)
  • src/Besql/Bit.Besql/wwwroot/bit-besql.js (1 hunks)
  • src/Bit.Build.props (1 hunks)
  • src/BlazorUI/Bit.BlazorUI/Scripts/general.ts (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj (1 hunks)
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js (1 hunks)
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1 hunks)
  • src/BlazorUI/Demo/Directory.Build.props (1 hunks)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js (1 hunks)
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts (1 hunks)
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts (1 hunks)
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.js (1 hunks)
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js (1 hunks)
  • src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts (1 hunks)
  • src/Bup/Bit.Bup/Scripts/bit-bup.ts (1 hunks)
  • src/Butil/Bit.Butil/Scripts/butil.ts (1 hunks)
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj (2 hunks)
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props (1 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (2 hunks)
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (2 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1 hunks)
  • src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj (1 hunks)
  • src/Websites/Careers/src/Directory.Build.props (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor.cs (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj (1 hunks)
  • src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj (1 hunks)
  • src/Websites/Platform/src/Directory.Build.props (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1 hunks)
  • src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj (1 hunks)
  • src/Websites/Sales/src/Directory.Build.props (1 hunks)
✅ Files skipped from review due to trivial changes (26)
  • src/Websites/Platform/src/Directory.Build.props
  • src/Bup/Bit.Bup/Scripts/bit-bup.ts
  • src/Websites/Careers/src/Directory.Build.props
  • src/BlazorUI/Demo/Directory.Build.props
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.js
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Build.props
  • src/Websites/Sales/src/Directory.Build.props
  • src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.js
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.published.js
  • src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/wwwroot/service-worker.published.js
  • src/BlazorUI/Bit.BlazorUI/Scripts/general.ts
  • src/Butil/Bit.Butil/Scripts/butil.ts
  • src/Bswup/Bit.Bswup.NewDemo/Bit.Bswup.NewDemo.Client/wwwroot/service-worker.js
  • src/Bup/Bit.Bup/Scripts/bit-bup.progress.ts
  • src/Websites/Careers/src/Bit.Websites.Careers.Shared/Bit.Websites.Careers.Shared.csproj
  • src/Websites/Platform/src/Bit.Websites.Platform.Server/Bit.Websites.Platform.Server.csproj
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Server/Bit.BlazorUI.Demo.Server.csproj
  • src/Templates/Boilerplate/Bit.Boilerplate/src/Client/Boilerplate.Client.Web/wwwroot/service-worker.published.js
  • src/Bswup/FullDemo/Client/wwwroot/service-worker.published.js
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.progress.ts
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.sw.ts
  • src/Bswup/Bit.Bswup/Scripts/bit-bswup.ts
  • src/BlazorUI/Demo/Bit.BlazorUI.Demo.Shared/Bit.BlazorUI.Demo.Shared.csproj
  • src/Websites/Sales/src/Bit.Websites.Sales.Shared/Bit.Websites.Sales.Shared.csproj
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty.Client/BlazorEmpty.Client.csproj
  • src/Templates/BlazorEmpty/Bit.BlazorEmpty/BlazorEmpty/BlazorEmpty.csproj
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build and test for release
🔇 Additional comments (18)
src/Besql/Bit.Besql/wwwroot/bit-besql.js (1)

2-2: Version update looks good!

The version string has been correctly updated to match the pre-release version.

src/Bswup/Bit.Bswup.Demo/wwwroot/service-worker.published.js (2)

1-1: Version comment update looks good!

The version comment has been correctly updated to match the pre-release version.


7-63: Verify the impact of commented-out service worker code.

Large sections of service worker functionality have been commented out, including:

  • External assets configuration
  • Asset caching during installation
  • Cache cleanup during activation
  • Response serving during fetch events

This change could affect offline capabilities and caching behavior.

Could you please clarify if commenting out this functionality is intentional for the pre-release version? This change seems significant but wasn't mentioned in the PR objectives.

src/Bit.Build.props (1)

30-30: Version property update looks good!

The ReleaseVersion property has been correctly updated to match the pre-release version. This update properly cascades to PackageVersion and PackageReleaseNotes URL.

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages8.props (1)

4-11: LGTM! Package versions are consistently updated.

All Bit packages have been updated to version 9.4.2-pre-01, maintaining consistency across the repository.

Also applies to: 51-51

src/Templates/Boilerplate/Bit.Boilerplate/src/Directory.Packages.props (1)

4-11: LGTM! Package versions are consistently updated.

All Bit packages have been updated to version 9.4.2-pre-01, maintaining consistency across the repository.

Also applies to: 54-54

src/Websites/Platform/src/Bit.Websites.Platform.Client/Pages/Templates/Templates03GettingStartedPage.razor (1)

177-178: LGTM! Installation instructions are correctly updated.

The installation instructions and commands have been updated to use version 9.4.2-pre-01, maintaining consistency with the package version updates.

src/Websites/Platform/src/Bit.Websites.Platform.Shared/Bit.Websites.Platform.Shared.csproj (1)

9-16: LGTM! Package references are correctly updated.

The package references for Bit.CodeAnalyzers and Bit.SourceGenerators have been updated to version 9.4.2-pre-01, maintaining consistency with the version updates across the repository.

src/Websites/Sales/src/Bit.Websites.Sales.Server/Bit.Websites.Sales.Server.csproj (1)

13-20: Version updates look good!

The package reference versions have been consistently updated to 9.4.2-pre-01, maintaining their existing configurations.

src/Websites/Careers/src/Bit.Websites.Careers.Server/Bit.Websites.Careers.Server.csproj (1)

13-20: Version updates are consistent!

The package reference versions match the updates in other project files, maintaining consistency across the solution.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Web/Bit.BlazorUI.Demo.Client.Web.csproj (1)

27-36: Version updates are consistent!

All Bit.* package references have been consistently updated to 9.4.2-pre-01, including Bit.Bswup.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Windows/Bit.BlazorUI.Demo.Client.Windows.csproj (1)

32-39: Version updates are consistent!

The package reference versions align with the updates in other project files.

src/Websites/Sales/src/Bit.Websites.Sales.Client/Bit.Websites.Sales.Client.csproj (2)

26-37: Version updates are consistent!

All Bit.* package references have been consistently updated to 9.4.2-pre-01.


20-24: Verify the impact of file handling changes.

The following changes to file handling might affect the build process:

  • compilerconfig.json moved from Content to None
  • appsettings.json moved from None to EmbeddedResource

Please ensure these changes don't impact:

  1. The compilation of SCSS files (compilerconfig.json)
  2. The runtime access to application settings (appsettings.json)
src/Websites/Careers/src/Bit.Websites.Careers.Client/Bit.Websites.Careers.Client.csproj (1)

26-37: LGTM! Package versions updated consistently.

Package versions have been updated from 9.4.1 to 9.4.2-pre-01, aligning with the prerelease version bump.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Core/Bit.BlazorUI.Demo.Client.Core.csproj (1)

19-26: LGTM! Package versions updated consistently.

Package versions have been updated from 9.4.1 to 9.4.2-pre-01, aligning with the prerelease version bump.

src/Websites/Platform/src/Bit.Websites.Platform.Client/Bit.Websites.Platform.Client.csproj (1)

26-38: LGTM! Package versions updated consistently.

Package versions have been updated from 9.4.1 to 9.4.2-pre-01, aligning with the prerelease version bump.

src/BlazorUI/Demo/Client/Bit.BlazorUI.Demo.Client.Maui/Bit.BlazorUI.Demo.Client.Maui.csproj (1)

88-96: LGTM! Package versions updated consistently.

Package versions have been updated from 9.4.1 to 9.4.2-pre-01, aligning with the prerelease version bump.

@ysmoradi ysmoradi merged commit 517f45f into bitfoundation:develop Feb 12, 2025
3 checks passed
@msynk msynk deleted the 9865-prerelease-v-9.4.2-pre-01 branch February 12, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prerelease v-9.4.2-pre-01
2 participants