-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add menu captions to the TV UI #459
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! The code looks good (apart from a few nitpicks about code style / white spaces).
I'm afraid we'll need to tweak the functionality and design though:
- When the MenuCaption gets displayed, the SettingsToggleButtons get pushed down. I don't think we should do that, the buttons must not move.
- The MenuCaption should be displayed when the SettingsToggleButton has the focus (e.g. when navigating via TAB there on desktop) as well as when the button is clicked (= menu is opened). The first part is not in place yet.
Co-authored-by: Daniel Weinberger <[email protected]>
Co-authored-by: Daniel Weinberger <[email protected]>
Co-authored-by: Daniel Weinberger <[email protected]>
Co-authored-by: Daniel Weinberger <[email protected]>
Conflicts: src/scss/skin-modern/_skin-tv.scss src/ts/uifactory.ts
…ered or "selected" (but not activated)
I've made a few changes to this PR:
@felix-hoc would appreciate if you could review this one. @bit-jacoba let me know if you're happy with that. |
(Need to check why the CI failed 🤔) |
(CI failure was just a tslint error, which is fixed now) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks OK from my side, just not sure about the design/concept. It feels a bit "unfinished". Perhaps we could at least center the labels underneath the buttons? But the Audio Track
one might be a bit too long.
Alternatively, what if we just had the label displayed when the menu is opened? So as a header to the select box.
…text when hovering/focusing the button
… is in the title bar (top) or controlbar (bottom)
I changed the approach quite a bit as I realized that all the buttons already have span/label elements included. There's now a new (optional) config option for all buttons (including However, I'm still not 100% happy with this, as long texts could be cut off for buttons on the right or left side, but I don't have a better idea. This is how it looks like now: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, IMO this approach is better 👍🏼
Could we also get rid of the blue glow in the background of the text?
I really tried but didn't manage. Happy to receive any suggestions or help 😅 |
Jira - https://bitmovin.atlassian.net/browse/SOL-3687
Checklist (for PR submitter and reviewers)
CHANGELOG
entry