-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new seekbar option to prevent label overlap #584
base: develop
Are you sure you want to change the base?
new seekbar option to prevent label overlap #584
Conversation
…d by this option the arrow below the label is hidden
Simon Oberhammer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Thanks for the submission! :) I tested it a bit - unfortunately, the thumbnails seem to jump around wildly when getting close to the edges, and also the arrow disappears: I think we need to find a different solution. |
wouldn't call it "wildly" ;) it moves inside so it doesn't overlap. any suggestions on a direction to take on this? |
Yeah I get that :) From a user perspective, it would be nice if the thumbnail would simply stop moving out of the frame, so it stays "attached" to the left/right edge when the mouse moves further out. I had a quick look but also couldn't come up with a better solution so far :/ we'll need to properly look into it. |
…umpy behavior; move the arrow too
i think i addressed both your concerns - the label now stays at the edge (with a bit of margin) instead of jumping away from it and the arrow keeps indicating the visible position Screencast.from.2024-02-28.13.09.31.webm |
any news on this? if you are worried about performance, i could throttle the overflow-prevention. |
potential fix for #569