Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dutch (nl) localisation #645

Merged
merged 3 commits into from
Aug 30, 2024
Merged

Add Dutch (nl) localisation #645

merged 3 commits into from
Aug 30, 2024

Conversation

lextas
Copy link
Contributor

@lextas lextas commented Aug 23, 2024

Description

Added localisation for Dutch (nl)

@CLAassistant
Copy link

CLAassistant commented Aug 23, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ lextas
❌ wasp898
You have signed the CLA already but the status is still pending? Let us recheck it.

@lextas lextas changed the title add Dutch (nl) localisation Add Dutch (nl) localisation Aug 23, 2024
@lextas lextas force-pushed the develop branch 2 times, most recently from a3e736e to c2bb992 Compare August 23, 2024 15:48
@wasp898
Copy link
Contributor

wasp898 commented Aug 29, 2024

Can you please add a changelog @lextas? For example https://github.com/bitmovin/bitmovin-player-ui/pull/647/files.

@lextas
Copy link
Contributor Author

lextas commented Aug 30, 2024

Yes will do, the default PR message said it would be created automatically so I assumed it would. Not sure how to resolve the merge conflict. Do I need to manually up the version? Or is that part automated?

@wasp898 wasp898 merged commit 8248c50 into bitmovin:develop Aug 30, 2024
1 of 2 checks passed
@wasp898
Copy link
Contributor

wasp898 commented Aug 30, 2024

Yes will do, the default PR message said it would be created automatically so I assumed it would. Not sure how to resolve the merge conflict. Do I need to manually up the version? Or is that part automated?

Sorry, didn't see your edited message.
Release is automatic based on the unreleased changelog entries. Conflict was just because something else was already merged since you opened the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants