[PW-11902] Improve auto-hide behavior with active dropdown menus #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o reflect, whether a component must remain visible or whether it can be hidden
…are components that must remain visible
…e are persistent components
wasp898
approved these changes
Sep 6, 2024
wasp898
deleted the
feature/PW-11902/improved-drop-down-list-auto-hide-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the auto-hide behavior of the UI when the dropdown menu of a
SelectBoxis shown.Before the UI would auto-hide after the specified timeout regardless of whether a dropdown menu was currently shown or not. With the changes introduced in this PR, the UI will now stay visible and auto-hiding will be disabled whenever a dropdown is shown.
In order to do so, the following changes were implemented:
Timeoutexecution to be suspended, meaning all calls tostartandresetwill be ignored until timeout execution is resumedViewModetoComponentwith the following values:Persistent: the component shall be visible at all times and UI auto-hiding shall be disabledTemporary: the component may be hidden at any timeSelectBoxto set itsViewModetoPersistentwhenever and as long as the dropdown of the associatedselecttag is shownUIContainerandSettingsPanelto suspend hide-timeout execution as long as there is at least one component with aPersistentview modeSelectBoxwould stay visible when the UI is hiddenChecklist (for PR submitter and reviewers)
CHANGELOGentry