Update main.go #4

imaustink · 2024-11-04T19:25:23Z

Testing some PR review automations here. PR can be safely ignored.

imaustink

Minor improvement suggested for error messaging consistency

imaustink · 2024-11-05T19:55:46Z

src/main.go

@@ -22,7 +22,7 @@ func NewTemporalCloudProvider(temporalCloudAdapter ITemporalCloudAdapter, config

 	err := temporalCloudAdapter.Flags().Parse(os.Args)
 	if err != nil {
-		return nil, fmt.Errorf("unable to parse flags: %v", err)
+		return nil, fmt.Errorf("failed to parse flags: %v", err)


Consider using a constant for error messages to ensure consistency and easy modifications across the codebase.

Update main.go

11e3663

This comment was marked as outdated.

Sign in to view

imaustink commented Nov 5, 2024

View reviewed changes

This comment was marked as duplicate.

Sign in to view

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update main.go #4

Update main.go #4

imaustink commented Nov 4, 2024 •

edited

Loading

This comment was marked as outdated.

This comment was marked as outdated.

imaustink left a comment

imaustink Nov 5, 2024

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

Update main.go #4

Are you sure you want to change the base?

Update main.go #4

Conversation

imaustink commented Nov 4, 2024 • edited Loading

This comment was marked as outdated.

This comment was marked as outdated.

imaustink left a comment

Choose a reason for hiding this comment

imaustink Nov 5, 2024

Choose a reason for hiding this comment

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

This comment was marked as duplicate.

imaustink commented Nov 4, 2024 •

edited

Loading