-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PM-14419] At-risk passwords change password service (#13279)
* [PM-14419] Introduce the change-login-password service and its default implementation * [PM-14419] Use the change login password service on the at-risk passwords page * [PM-14419] Add unit tests * [PM-14419] Use existing fixed test environment * [PM-14419] Add mock implementation for ChangeLoginPasswordService in at-risk passwords tests * [PM-14419] Linter
- Loading branch information
1 parent
a0c3854
commit c67e6df
Showing
7 changed files
with
319 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
libs/vault/src/abstractions/change-login-password.service.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view"; | ||
|
|
||
| export abstract class ChangeLoginPasswordService { | ||
| /** | ||
| * Attempts to find a well-known change password URL for the given cipher. Only works for Login ciphers with at | ||
| * least one http/https URL. If no well-known change password URL is found, the first URL is returned. | ||
| * Non-Login ciphers and Logins with no valid http/https URLs return null. | ||
| */ | ||
| abstract getChangePasswordUrl(cipher: CipherView): Promise<string | null>; | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
157 changes: 157 additions & 0 deletions
157
libs/vault/src/services/default-change-login-password.service.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,157 @@ | ||
| /** | ||
| * Jest needs to run in custom environment to mock Request/Response objects | ||
| * @jest-environment ../../libs/shared/test.environment.ts | ||
| */ | ||
|
|
||
| import { mock } from "jest-mock-extended"; | ||
|
|
||
| import { ApiService } from "@bitwarden/common/abstractions/api.service"; | ||
| import { CipherType } from "@bitwarden/common/vault/enums"; | ||
| import { CipherView } from "@bitwarden/common/vault/models/view/cipher.view"; | ||
| import { LoginUriView } from "@bitwarden/common/vault/models/view/login-uri.view"; | ||
| import { LoginView } from "@bitwarden/common/vault/models/view/login.view"; | ||
|
|
||
| import { DefaultChangeLoginPasswordService } from "./default-change-login-password.service"; | ||
|
|
||
| describe("DefaultChangeLoginPasswordService", () => { | ||
| let service: DefaultChangeLoginPasswordService; | ||
|
|
||
| let mockShouldNotExistResponse: Response; | ||
| let mockWellKnownResponse: Response; | ||
|
|
||
| const mockApiService = mock<ApiService>(); | ||
|
|
||
| beforeEach(() => { | ||
| mockApiService.nativeFetch.mockClear(); | ||
|
|
||
| // Default responses to success state | ||
| mockShouldNotExistResponse = new Response("Not Found", { status: 404 }); | ||
| mockWellKnownResponse = new Response("OK", { status: 200 }); | ||
|
|
||
| mockApiService.nativeFetch.mockImplementation((request) => { | ||
| if ( | ||
| request.url.endsWith("resource-that-should-not-exist-whose-status-code-should-not-be-200") | ||
| ) { | ||
| return Promise.resolve(mockShouldNotExistResponse); | ||
| } | ||
|
|
||
| if (request.url.endsWith(".well-known/change-password")) { | ||
| return Promise.resolve(mockWellKnownResponse); | ||
| } | ||
|
|
||
| throw new Error("Unexpected request"); | ||
| }); | ||
| service = new DefaultChangeLoginPasswordService(mockApiService); | ||
| }); | ||
|
|
||
| it("should return null for non-login ciphers", async () => { | ||
| const cipher = { | ||
| type: CipherType.Card, | ||
| } as CipherView; | ||
|
|
||
| const url = await service.getChangePasswordUrl(cipher); | ||
|
|
||
| expect(url).toBeNull(); | ||
| }); | ||
|
|
||
| it("should return null for logins with no URIs", async () => { | ||
| const cipher = { | ||
| type: CipherType.Login, | ||
| login: Object.assign(new LoginView(), { uris: [] as LoginUriView[] }), | ||
| } as CipherView; | ||
|
|
||
| const url = await service.getChangePasswordUrl(cipher); | ||
|
|
||
| expect(url).toBeNull(); | ||
| }); | ||
|
|
||
| it("should return null for logins with no valid HTTP/HTTPS URIs", async () => { | ||
| const cipher = { | ||
| type: CipherType.Login, | ||
| login: Object.assign(new LoginView(), { | ||
| uris: [{ uri: "ftp://example.com" }], | ||
| }), | ||
| } as CipherView; | ||
|
|
||
| const url = await service.getChangePasswordUrl(cipher); | ||
|
|
||
| expect(url).toBeNull(); | ||
| }); | ||
|
|
||
| it("should check the origin for a reliable status code", async () => { | ||
| const cipher = { | ||
| type: CipherType.Login, | ||
| login: Object.assign(new LoginView(), { | ||
| uris: [{ uri: "https://example.com" }], | ||
| }), | ||
| } as CipherView; | ||
|
|
||
| await service.getChangePasswordUrl(cipher); | ||
|
|
||
| expect(mockApiService.nativeFetch).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| url: "https://example.com/.well-known/resource-that-should-not-exist-whose-status-code-should-not-be-200", | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it("should attempt to fetch the well-known change password URL", async () => { | ||
| const cipher = { | ||
| type: CipherType.Login, | ||
| login: Object.assign(new LoginView(), { | ||
| uris: [{ uri: "https://example.com" }], | ||
| }), | ||
| } as CipherView; | ||
|
|
||
| await service.getChangePasswordUrl(cipher); | ||
|
|
||
| expect(mockApiService.nativeFetch).toHaveBeenCalledWith( | ||
| expect.objectContaining({ | ||
| url: "https://example.com/.well-known/change-password", | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it("should return the well-known change password URL when successful at verifying the response", async () => { | ||
| const cipher = { | ||
| type: CipherType.Login, | ||
| login: Object.assign(new LoginView(), { | ||
| uris: [{ uri: "https://example.com" }], | ||
| }), | ||
| } as CipherView; | ||
|
|
||
| const url = await service.getChangePasswordUrl(cipher); | ||
|
|
||
| expect(url).toBe("https://example.com/.well-known/change-password"); | ||
| }); | ||
|
|
||
| it("should return the original URI when unable to verify the response", async () => { | ||
| mockShouldNotExistResponse = new Response("Ok", { status: 200 }); | ||
|
|
||
| const cipher = { | ||
| type: CipherType.Login, | ||
| login: Object.assign(new LoginView(), { | ||
| uris: [{ uri: "https://example.com" }], | ||
| }), | ||
| } as CipherView; | ||
|
|
||
| const url = await service.getChangePasswordUrl(cipher); | ||
|
|
||
| expect(url).toBe("https://example.com"); | ||
| }); | ||
|
|
||
| it("should return the original URI when the well-known URL is not found", async () => { | ||
| mockWellKnownResponse = new Response("Not Found", { status: 404 }); | ||
|
|
||
| const cipher = { | ||
| type: CipherType.Login, | ||
| login: Object.assign(new LoginView(), { | ||
| uris: [{ uri: "https://example.com" }], | ||
| }), | ||
| } as CipherView; | ||
|
|
||
| const url = await service.getChangePasswordUrl(cipher); | ||
|
|
||
| expect(url).toBe("https://example.com"); | ||
| }); | ||
| }); |
Oops, something went wrong.